Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...

Eduardo Warszawski ewarszaw at redhat.com
Thu Sep 1 07:57:45 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/lvm.py
Line 984:     if os.path.exists(lvPath(vgName, lvName)):
This verification should be removed as stated in the comment below and is here only for debuging purposes.
Path activation status is not  an issue outside of the lvm module.
Therefore is better that such function does not exists, then can't be used outside.

--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list