Change in vdsm[master]: Related to BZ#744704 - Do not stop SPM task if in 'racquirin...

Igor Lvovsky ilvovsky at redhat.com
Thu Oct 27 10:21:31 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#744704 - Do not stop SPM task if in 'racquiring' state
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/task.py
Line 149:         recovered: [recovering],
Line 150:         failed: [recovering, aborting, raborting],
Line 151:     }
Line 152:     _done = [finished, recovered, failed]
Line 153:     _recovering = [racquiring, recovering]
I used list because it was already used in all different occurrences in this particular code. So, let's stay compatible with rest code.
It was very specific change in very complicated and ugly code and the last thing that we need here it's massive changes.
Line 154: 
Line 155: 
Line 156:     def __init__(self, state = None):
Line 157:         try:


--
To view, visit http://gerrit.usersys.redhat.com/1042
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list