Change in vdsm[master]: BZ#744755 daemonize HSM_MailMonitor thread
Igor Lvovsky
ilvovsky at redhat.com
Mon Oct 24 06:41:10 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: BZ#744755 daemonize HSM_MailMonitor thread
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 90: func - function to call
Line 91: dom - argument to pass to func()
Line 92: """
Line 93: threading.Thread.__init__(self)
Line 94: self.setDaemon(True)
This is not related to this patch.
Looks like same to Federico's patch:
http://gerrit.usersys.redhat.com/#change,1049
Line 95: self._statscache = dict(result=
Line 96: dict(code=200, lastCheck=0.0, delay='0', valid=True))
Line 97: self._statsdelay = config.getint('irs', 'sd_health_check_delay')
Line 98: self._statsletrun = True
....................................................
File vdsm/storage/storage_mailbox.py
Line 242: self._initMailbox() # Read initial mailbox state
Line 243: self._msgCounter = 0
Line 244: self._sendMail() # Clear outgoing mailbox
Line 245: threading.Thread.__init__(self)
Line 246: self.setDaemon(True)
What about SPM_mailbox?
Line 247: self.start()
Line 248:
Line 249: def _initMailbox(self):
Line 250: # Sync initial incoming mail state with storage view
--
To view, visit http://gerrit.usersys.redhat.com/1036
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27d7e7e1d1e99f6119fd4cc6ab1a10654236c57d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list