Change in vdsm[master]: Move iscsid.conf template outside of the source file
danken at redhat.com
danken at redhat.com
Sun Oct 23 18:33:49 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: Move iscsid.conf template outside of the source file
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm.spec.in
Line 294: %{_datadir}/%{vdsm_name}/storage/resourceFactories.py*
Line 295: %{_datadir}/%{vdsm_name}/storage/outOfProcess.py*
Line 296: %{_datadir}/%{vdsm_name}/storage/processPool.py*
Line 297: %{_datadir}/%{vdsm_name}/storage/iscsi.py*
Line 298: %{_datadir}/%{vdsm_name}/storage/iscsid.conf.template*
no need in final astrisk
Line 299: %{_datadir}/%{vdsm_name}/storage/devicemapper.py*
Line 300: %{_datadir}/%{vdsm_name}/storage/securable.py*
Line 301: %{_datadir}/%{vdsm_name}/storage/multipath.py*
Line 302: %{_datadir}/%{vdsm_name}/storage/sdc.py*
....................................................
File vdsm/storage/Makefile.am
Line 48: securable.py
Line 49:
Line 50: EXTRA_DIST = \
Line 51: 12-vdsm-lvm.rules
Line 52: iscsid.conf.template
that's not enough - you should actually install it somewhere.
Line 53:
Line 54: check-local:
Line 55: python $(srcdir)/storage_exception.py
Line 56:
--
To view, visit http://gerrit.usersys.redhat.com/1034
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list