Change in vdsm[master]: Handle EAGAIN and EINTR in ProcessPool.runExternally
danken at redhat.com
danken at redhat.com
Fri Oct 21 21:45:17 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: Handle EAGAIN and EINTR in ProcessPool.runExternally
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/processPool.py
Line 145: raise
Line 146:
Line 147: if not pollres:
Line 148: helper.interrupt()
Line 149: if not helper.pipe.poll(self._gracePeriod):
won't you need to have the same handling here?
would you give some background about this patch? it seems quite serious - an exception causes a leaked helper processes.
Line 150: helper.kill()
Line 151: self._helperPool[i] = None
Line 152: raise Timeout("Operation Stuck")
Line 153:
--
To view, visit http://gerrit.usersys.redhat.com/1051
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1d0f35af9db6e237c87b00438b9ce3ded9faa8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list