Change in vdsm[master]: Made the logging mechanism more generic

danken at redhat.com danken at redhat.com
Sun Oct 16 11:17:29 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Made the logging mechanism more generic
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

marking as known broken.

....................................................
File vdsm/storage/hsm.py
Line 73:     conCopy = con.copy()
Line 74:     for key in conCopy:
Line 75:         if key.upper() == 'PASSWORD':
Line 76:             conCopy[key] = '******'
Line 77:     return conCopy()
conCopy is not callable
Line 78: 
Line 79: def loggableConList(conList):
Line 80:     cons = []
Line 81:     for con in conList:


--
To view, visit http://gerrit.usersys.redhat.com/990
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38b4a16803b03043144acf62e9fb65c3b1b0a3c5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list