Change in vdsm[master]: BZ#741203 Don't return a value in domain selftest
Saggi Mizrahi
smizrahi at redhat.com
Sun Oct 16 10:12:48 UTC 2011
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/sd.py
Line 351:
Line 352: def selftest(self):
Line 353: """
Line 354: Run internal self test
Line 355: """
pass?
Line 356:
Line 357: def upgrade(self, targetVersion):
Line 358: """
Line 359: Upgrade the domain to more advance version
....................................................
File vdsm/storage/sp.py
Line 1303: stats['masterValidate'] = domain.validateMaster()
Line 1304: except se.StorageException, e:
Line 1305: code = e.code
Line 1306: except (OSError, Timeout):
Line 1307: code = se.StorageDomainAccessError.code
except Exception:
code = 200
Line 1308:
Line 1309: return stats, code
Line 1310:
Line 1311:
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list