Change in vdsm[master]: BZ#743549 - Allow concurrency in task manager

Igor Lvovsky ilvovsky at redhat.com
Mon Oct 10 16:54:26 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: BZ#743549 - Allow concurrency in task manager
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm/storage/taskManager.py
Line 103:         self.log.debug("Entry.")
Line 104:         subRes = {}
Line 105:         for taskID, task in self._tasks.items():
Line 106:             if not tag or tag in task.getTags():
Line 107:                 subRes[taskID] = self.getTaskStatus(taskID)
I don't think it's right. I just uploaded new patchset.
The problem is that task maybe cleared right after we got it via _tasks.items().
In such case I don't want return status/info for this task else we can get clearTask twice from rhev-m
Line 108:         self.log.debug("Return: %s", subRes)
Line 109:         return subRes
Line 110: 
Line 111: 


Line 179:         self.log.debug("Entry.")
Line 180:         subRes = {}
Line 181:         for taskID, task in self._tasks.items():
Line 182:             if not tag or tag in task.getTags():
Line 183:                 subRes[taskID] = self.getTaskInfo(taskID)
see above
Line 184:         self.log.debug("Return. Response: %s", subRes)
Line 185:         return subRes
Line 186: 
Line 187: 


--
To view, visit http://gerrit.usersys.redhat.com/997
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b04a8b22ac40e39e89bbbee56309c015586fc1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin at redhat.com>


More information about the vdsm-patches mailing list