Change in vdsm[master]: BZ#741658 Move VM to Down if libvirt reports VIR_ERR_NO_DOMA...

Igor Lvovsky ilvovsky at redhat.com
Sat Oct 8 17:57:52 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: BZ#741658 Move VM to Down if libvirt reports VIR_ERR_NO_DOMAIN
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 190:     def handleStatsException(self, ex):
Line 191:         if hasattr(ex, "get_error_code"):
Line 192:             if (ex.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN
Line 193:                     and self._vm.lastStatus not in
Line 194:                         ('Saving State', 'Migration Source', 'Down')):
I am not sure, but why only these states?
do we have the enum of all possible states? It's very difficult (at least for me)
 to remember all possible states.
Maybe it's a good time add such enum?
Line 195:                 self._log.debug("VM not found, moving to Down", exc_info=True)
Line 196:                 self._vm.setDownStatus(ERROR, str(ex))
Line 197:                 return True
Line 198:         return False


--
To view, visit http://gerrit.usersys.redhat.com/984
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6262fb2504534c56fdec246937423d629f92e13
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list