Change in vdsm[master]: BZ#740887 Tune cache dirty ratio
danken at redhat.com
danken at redhat.com
Wed Oct 5 17:26:42 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#740887 Tune cache dirty ratio
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vdsmd.in
Line 360:
Line 361: configure_sysctl()
Line 362: {
Line 363: local VDSM_SYSCTL_HEAD
Line 364: VDSM_SYSCTL_HEAD="# VDSM section begin (v.1)"
it would have been more robust to set this to "# VDSM section begin ", and append it with the version. then the same var could be used by sed.
Line 365: grep -q "$VDSM_SYSCTL_HEAD" /etc/sysctl.conf
Line 366: if [ $? -ne 0 ]; then
Line 367: echo $"Configuring sysctl for vdsm..."
Line 368: sed -e '/vm.dirty_ratio/d' \
Line 393: args="$args $LCONF $QCONF $LDCONF"
Line 394: ;;
Line 395: esac
Line 396: configure_libvirt $args
Line 397: configure_sysctl $args
no use for "$args" here.
Line 398: }
Line 399:
Line 400: stop_libvirtd_sysv() {
Line 401: # stop libvirt SysV service if we intend to configure upstart
--
To view, visit http://gerrit.usersys.redhat.com/970
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
More information about the vdsm-patches
mailing list