Change in vdsm[master]: Related to BZ#743272 - dirList IS and WAS dirList.

danken at redhat.com danken at redhat.com
Tue Oct 4 19:23:13 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#743272 - dirList IS and WAS dirList.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/taskManager.py
Line 197:     def loadDumpedTasks(self, store):
Line 198:         if not os.path.exists(store):
Line 199:             self.log.debug("task dump path %s does not exist.", store)
Line 200:             return
Line 201:         #taskID is the root part of each (root.ext) entry in the dump task dir
why did you remove the former code? it was so clear and succinct!
Line 202:         tasksIDs = [os.path.splitext(tid)[0] for tid in os.listdir(store)]
Line 203:         for taskID in tasksIDs:
Line 204:             self.log.debug("Loading dumped task %s", taskID)
Line 205:             try:


--
To view, visit http://gerrit.usersys.redhat.com/993
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fbcdb4076a5c16fd74754350464f382636ff419
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list