Change in vdsm[master]: BZ#737722 Do not pass cmdline args to grub

danken at redhat.com danken at redhat.com
Mon Oct 3 16:21:25 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#737722 Do not pass cmdline args to grub
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line -2
Line -1
Line 0
Line 1: Parent:     6a469b6d (BZ#716573 make vdsm's `ulimit -n` configurable)
Line 2: Author:     Yotam Oron <yoron at redhat.com>
is it much different than Alan's patch?
Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit:     Yotam Oron <yoron at redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6: 


Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit:     Yotam Oron <yoron at redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6: 
Line 7: BZ#737722 Do not pass cmdline args to grub
Please mention this is RHEV-H cmdline
Line 8: 
Line 9: cmdline args are only needed in installation time,
Line 10: oVirt has a builtin functionallity to not pass the args
Line 11: to grub


--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list