Change in vdsm[master]: Change safelease APIs to match SANLock flow
ilvovsky at redhat.com
ilvovsky at redhat.com
Wed Nov 30 14:28:09 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: Change safelease APIs to match SANLock flow
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File vdsm/storage/sp.py
Line 727: for sdUUID in self.getDomains():
use activeOnly on getDomains
Line 736: # on this domain.
Add rollback
Line 758: for sdUUID in self.getDomains():
activeOnly domains should be released
Line 1021: dom.acquireHostId(self.id)
should be moved to activateSD.
Line 1022: dom.acquireClusterLock(self.id)
Saggi, why we need acquireClusterLock here?
It's look as we need to consider again using of acquireClusterLock on all places.
Line 1081: dom.releaseHostId(self.id)
move it to the deactivateSD
--
To view, visit http://gerrit.ovirt.org/221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d5410ad76b22b037e8cac7e667817fb9ef56f6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list