Change in vdsm[master]: Extracted image related functinality to another class

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Nov 30 08:15:05 UTC 2011


Eduardo has posted comments on this change.

Change subject: Extracted image related functinality to another class
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 1154:         pool = self.getPool(spUUID)
It's true that if you are SPM you are connected to the pool, but you are changing the "arcane" original semantic.

....................................................
File vdsm/storage/Makefile.am
Line 24: 	image.py \
Both image.py and legacyImageManipulator are required?

....................................................
File vdsm/storage/sp.py
Line 131: >>>>>>> 7a6faeb... Extracted image related functinality to another class
?

--
To view, visit http://gerrit.ovirt.org/191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list