Change in vdsm[master]: Add NoIntr utility class

danken at redhat.com danken at redhat.com
Tue Nov 29 16:39:42 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Add NoIntr utility class
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/misc.py
Line 1296:             func_args = [self._getArgValue(x) for x in args]
gosh, sorry for having you waited for a response for over 2 weeks. gerrit should have a means to trigger a "needinfo" from a specific user just like bugzilla...

I meant that you have a single translator, which is used for all arguments. Typically, each argument would need a different translation. For example, select(2) would need the timeout translation only for its last parameter.

--
To view, visit http://gerrit.ovirt.org/199
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8cd7f2c6ef8c4845fca617a0423b922fc81cf0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list