Change in vdsm[master]: Use the vdsm user and group macro consistently

fsimonce at redhat.com fsimonce at redhat.com
Mon Nov 28 10:10:06 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Use the vdsm user and group macro consistently
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/sudoers.vdsm.in.in
Line 18:     @CHOWN_PATH@ @VDSMUSER@\:@QEMUGROUP@ *, \
The problem is that we probably want to retain the flexibility given by VDSM_USER/GROUP, DISKIMAGE_USER/GROUP and METADATA_USER/GRUP but we don't want the @MACROS@ defines to increase with many identical values. At the moment the idea was to use few needed macros to set the constants (many clash to the same users/groups, eg: the vdsm user is the metadata user). Therefore the "inconsistency" is both here and in constants where the same macros are mapped to be used for different tasks. I'd be more happy to create a 1-to-1 relation between macros and constants if we're sure that we really need the flexibility given by so many different definitions.

--
To view, visit http://gerrit.ovirt.org/386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id12c093cdc01ab3dbfac36eaf1ab18f48ff5b5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list