Change in vdsm[master]: Use the defined constants in iscsi.py

fsimonce at redhat.com fsimonce at redhat.com
Wed Nov 23 12:27:28 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Use the defined constants in iscsi.py
......................................................................


Patch Set 1:

> (too bad these *constants* are /mutable/ lists...)

Like it's not annoying me too... :-)
Problem is that you can't easily add a tuple and a list  (without losing some readability), and that is required because sometimes we build the command line incrementally.
I'll look into it a little bit though.

--
To view, visit http://gerrit.ovirt.org/354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f2b9f8f846729bd62bbd17660ff1a197b311956
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list