Change in vdsm[master]: BZ#753625 honor displayNetwork again

danken at redhat.com danken at redhat.com
Fri Nov 18 21:00:02 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#753625 honor displayNetwork again
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 932:             listen.setAttribute('network', '%s%s' % (configNetwork.NETPREFIX, \
do you have anything against the simple + operator?

no need to use backslash to connect lines if inside parenthesis.

--
To view, visit http://gerrit.ovirt.org/255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia403496b2df9800ad027b0bab48f4eed4e75c2de
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list