Change in vdsm[master]: Return domXml and its md5 per VM.

danken at redhat.com danken at redhat.com
Thu Nov 17 09:33:28 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Return domXml and its md5 per VM.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 29: from hashlib import md5
on one had, md5 is passe'. on the other hand, we do not really need crypto strength.
should we use a simpler lighter algorithm? CRC? Jenkins?

Line 1356:         vm.Vm.status(self)
I think it is nicer to copy the output, and not assume (the sad fact) that 'status' updates conf.

Line 1358:         # _lastXMLDesc created at the end of LibvirtVM object creation
_lastXMLDesc attribute is created on __init__. It will always be there. Is there any reason to check it every time?

Line 1367:         stats['domxmlMD5'] = md5(self._lastXMLDesc).hexdigest()
please call it "hash", I do not think we should commit ourselves to md5.

--
To view, visit http://gerrit.ovirt.org/235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3a97fa998d0f52ebe752024c62b8ec16c32c78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list