Change in vdsm[master]: Simplify Drive.libvirtName().

fsimonce at redhat.com fsimonce at redhat.com
Thu Nov 17 08:59:17 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Simplify Drive.libvirtName().
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 71:         return "".join((preffix, letter))
I remember Dan wanted to support more than 26 disks (just like libvirt does, eg: hdaa hdab, etc...). "preffix" is a typo. I'd use something simpler, clearer and faster as: "return prefix + letter".

--
To view, visit http://gerrit.ovirt.org/271
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idce3ad8b10a9e75f2c93a83d1ca071d4841ce744
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list