Change in vdsm[master]: Adding shared raw disk feature.

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Nov 14 16:21:54 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Adding shared raw disk feature.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/clientIF.py
Line 548:         rc, out, err  = storage.misc.execCmd([constants.EXT_BLKID, "-U", uuid], sudo=False)
why sudo=false?

Line 551:             raise vm.VolumeError(uuid)
what is this error? how VolumeError is related to this?

Line 591:                 self.log.info("Avoiding tear down drive %s", str(drive))
why 'Avoiding ...' ?

--
To view, visit http://gerrit.ovirt.org/212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list