Change in vdsm[master]: Strip the trailing newline from libvirt password

danken at redhat.com danken at redhat.com
Mon Nov 14 16:15:04 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Strip the trailing newline from libvirt password
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

sorry..

....................................................
File vdsm/libvirtconnection.py
Line 103:                                'libvirt_password').readline().rstrip()
I just HATE this "password" feature...
but this fix would disallow passwords ending with spaces.

--
To view, visit http://gerrit.ovirt.org/216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2e5fe67384e15dd96b45b9ff890ecdd9ed4233e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list