Change in vdsm[master]: Fix: HSM should not write metadata (*BlkSize)

fsimonce at redhat.com fsimonce at redhat.com
Mon Nov 14 12:49:41 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Fix: HSM should not write metadata (*BlkSize)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 248:             # 512 by Saggi "Trust me (Smoch Alai (sic))"
What if an old domain (without the keys) is cloned to a 4K bs device? It will be treated as a 512 bs device and we should hope that it will fail for some reason before corrupting anything. Using lvm.getVGBlockSizes would not make it better though.

--
To view, visit http://gerrit.ovirt.org/201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96fdbc69071d014c7443abce61f7601ea593a378
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list