Change in vdsm[master]: Extracted image related functinality to another class

Federico Simoncelli fsimonce at redhat.com
Thu Nov 10 09:04:00 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Extracted image related functinality to another class
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2011-10-30 18:01:50 +0200
Line 4: Commit:     Saggi Mizrahi <smizrahi at redhat.com>
Line 5: CommitDate: 2011-11-10 12:47:04 +0200
Line 6: 
Line 7: Extracted image related functinality to another class
typo
Line 8: 
Line 9: This will allow me to later have different image manipulator
Line 10: implementation in the pool.
Line 11: 


....................................................
File vdsm/storage/Makefile.am
Line 46: 	threadPool.py \
Line 47: 	volume.py \
Line 48: 	securable.py \
Line 49: 	domainMonitor.py \
Line 50: 	legacyImageManipulator.py \
these were alphabetically ordered
Line 51: 	iscsid.conf.template
Line 52: 
Line 53: EXTRA_DIST = \
Line 54: 	12-vdsm-lvm.rules


....................................................
File vdsm/storage/sp.py
Line 550:         except:
Line 551:             self.id = None
Line 552:             raise
Line 553:         try:
Line 554:             self._setSafe()
Why are you squashing here the fix for the change 1098? What does this has to do with image functionality? Moreover this part was added only recently after change 1098.
Line 555:             try:
Line 556:                 # Mark 'master' domain
Line 557:                 # We should do it before actually attaching this domain to the pool.
Line 558:                 # During 'master' marking we create pool metadata and each attached


--
To view, visit http://gerrit.usersys.redhat.com/1074
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list