Change in vdsm[master]: Move domain monitor out of sp.py

Saggi Mizrahi smizrahi at redhat.com
Tue Nov 8 13:50:00 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: Move domain monitor out of sp.py
......................................................................


Patch Set 2: (2 inline comments)

I'll fix this promptly

....................................................
File vdsm/storage/domainMonitor.py
Line 24:         #         needed. Keep exposing for BC. Remove and use
Line 25:         #         warning mechanizm.
Line 26:         self.VgMdUtilization = (0, 0)
Line 27:         self.VgMdHasEnoughFreeSpace = True
Line 28:         self.VgMdFreeBelowThreashold = False
Sorry, I'll mixCase the var
Line 29: 
Line 30:     def update(self, st):
Line 31:         for attr in self.__slots__:
Line 32:             self.setattr(attr, getattr(st, attr))


....................................................
File vdsm/storage/sp.py
Line 1480: 
Line 1481:         for sdUUID in monitoredDomains:
Line 1482:             if sdUUID not in activeDomains:
Line 1483:                 try:
Line 1484:                     self.domainMonitor.startMonitoring(sdCache.produce(sdUUID))
Ooopsy, I got them mixed up
Line 1485:                     self.log.debug("sp `%s` stopped monitoring domain `%s`" % (self.spUUID, sdUUID))
Line 1486:                 except se.StorageException:
Line 1487:                     self.log.error("Unexpected error while trying to stop monitoring domain `%s`", sdUUID, exc_info=True)
Line 1488: 


--
To view, visit http://gerrit.usersys.redhat.com/1094
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list