Change in vdsm[master]: BZ#751629 - Avoid migrate master if MSD is obsolete.

Igor Lvovsky ilvovsky at redhat.com
Mon Nov 7 08:46:00 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1110:             if new_msdUUID != BLANK_POOL_UUID:
Line 1111:                 #Trying to migrate master failed to reach actual msd.
Line 1112:                 raise se.StorageDomainAccessError(sdUUID)
Line 1113:         else:
Line 1114:             if self.masterDomain.sdUUID == sdUUID:
Edu is right, 
But let's consider to change isMaster() to verify master version in additionally to role
Line 1115:                 #Maybe there should be information in the exception that the UUID is
Line 1116:                 #not invalid because of its format but because it is equal to the SD. Will be less confusing.
Line 1117:                 #TODO: verify in masterMigrate().
Line 1118:                 if sdUUID == new_msdUUID:


--
To view, visit http://gerrit.usersys.redhat.com/1091
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list