Change in vdsm[master]: [WIP] New repository system

Igor Lvovsky ilvovsky at redhat.com
Thu Nov 3 07:34:13 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: [WIP] New repository system
......................................................................


Patch Set 6: (3 inline comments)

....................................................
File vdsm/storage/storageRepository/engines/localFS.py
Line 3: import pickle
Line 4: import uuid
Line 5: from contextlib import contextmanager
Line 6: import glob
Line 7: from storageRepository.engines.common import DCAP_SPARSE_SLABS
what is storageRepository.engines.common?
where is it?
Line 8: 
Line 9: def safeWrite(path, data):
Line 10:     tmpPath = path + ".tmp"
Line 11:     with open(tmpPath, "wb") as f:


Line 178: 
Line 179:             yield os.path.basename(path)
Line 180: 
Line 181: def create(self, path):
Line 182:     # There is no bootstrapping for this kind of repository
why? what is bootstrapping here?
Who is know (except youself)  what is a purposes of all these functions?
Can you please explain somewhere (docstrings, comments, reference to some docs, ....).
Line 183:     return
Line 184: 
Line 185: ENGINE_INFO = ("localfs", create, LocalFsRepo)
Line 186


....................................................
File vdsm/storage/storageRepository/factory.py
Line -3
Line -2
Line -1
Line 0
Line 1: from urllib2 import urlparse
I think 'urlparse' placed in module 'urlparse' and not urllib2 (at least in 2.7)
http://docs.python.org/library/urlparse.html?highlight=urlparse#module-urlparse
Line 2: from glob import iglob
Line 3: import os
Line 4: import logging
Line 5: 


--
To view, visit http://gerrit.usersys.redhat.com/1080
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21fc36b33720da9529df40ddf6297fcb4fd4f3bc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list