Change in vdsm[master]: Fixed device mapper failing on partition check for non dm de...
Igor Lvovsky
ilvovsky at redhat.com
Thu Nov 3 05:10:06 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: Fixed device mapper failing on partition check for non dm devices
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/devicemapper.py
Line 109: if os.path.exists(possiblePartPath):
Line 110: return True
Line 111:
Line 112: if not isVirtualDevice(devName) or not isDmDevice(devName):
Line 113: return False
Is it a right check? I am a little bit confusing...
can you explain please, why?
Line 114:
Line 115:
Line 116: mpathName = getDevName(dmName)
Line 117: for holder in getHolders(dmName):
--
To view, visit http://gerrit.usersys.redhat.com/1078
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b4713d7e0ee04722e82887378f448243241c631
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list