Change in vdsm[master]: Avoid unnecesary produce-invalidate-produce on SD conf chang...

Saggi Mizrahi smizrahi at redhat.com
Wed Nov 2 14:24:38 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: Avoid unnecesary produce-invalidate-produce on SD conf changes.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 530:     def releaseClusterLock(self):
Line 531:         self.masterDomain.releaseClusterLock()
Line 532: 
Line 533:     @unsecured
Line 534:     def validateNewDomainConf(self, sdUUID, nextState):
This name is not good, use something that describes what the function does
Line 535:         domainConfs = self.getDomains()
Line 536: 
Line 537:         if sdUUID not in domainConfs.iterkeys():
Line 538:             raise se.StorageDomainNotInPool(self.spUUID, sdUUID)


--
To view, visit http://gerrit.usersys/1081
To unsubscribe, visit http://gerrit.usersys/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5165b92974145bcd26ca50648a65a6bfe282eb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list