Change in vdsm[master]: BZ#716919 - Update guest cpu running state after underlying ...

danken at redhat.com danken at redhat.com
Thu Jul 28 06:49:16 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#716919 - Update guest cpu running state after underlying VM is continued
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)

-1 for visibility

....................................................
File vdsm/vm.py
Line 656:             self._underlyingPause()
Why are you not putting the updateGuestCpuRunning() call here? why's the additional 'try' block?

Line 661:                 if hasattr(self, 'updateGuestCpuRunning'):
In my opinion, this hasattr is much uglier than a possible future empty implementation.

--
To view, visit http://gerrit.usersys.redhat.com/695
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3bb3bd2ec985b42bdaea19ce334f53234df4f11
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list