Change in vdsm[master]: Add "devcapacity" to PV info

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jul 25 10:18:47 UTC 2011


Juan Hernandez has posted comments on this change.

Change subject: Add "devcapacity" to PV info
......................................................................


Patch Set 2:

I already proposed using "getDeviceInfo" for each device, but there we find another potential performance problem: it needs to be invoked once per LUN. It will be a problem when a lot of LUNs are being added to the storage domain.

Take a look at (abandoned) change I42187b9e922a5780d87554b03e0581238ec4921c in RHEVM.

How complicated will be adding a bulk "getDeviceInfo" operation? I mean, an operation that receives a list of LUN UUIDS instead of just one.

Not probably for 3.0, but maybe it is good to start a discussion about this kind of bulk operations. They help reducing network round trips and improving performance.

--
To view, visit http://gerrit.usersys.redhat.com/734
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0bd3c94a6e4999cb91f96c798a0108890321fbd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list