Change in vdsm[master]: BZ#720981 - Sometimes devices have whitespace in their name ...

danken at redhat.com danken at redhat.com
Wed Jul 27 10:31:59 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#720981 - Sometimes devices have whitespace in their name file
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 24:                 if f.read().strip() == deviceMultipathName:
'wouldn't it be more correct to avoid stripping the device name in multipath.getMPDevsIter() ?
Think about two devices, one named "  " and the other "     ". If it's a legal naming, we should differentiate between the two.

--
To view, visit http://gerrit.usersys.redhat.com/751
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id99ab9b8b210616ef13b8acc7ddf2d5ce3f14553
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>


More information about the vdsm-patches mailing list