Change in vdsm[master]: Use system-uuid parameter in dmidecode command

danken at redhat.com danken at redhat.com
Sun Jul 24 20:55:50 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Use system-uuid parameter in dmidecode command
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/utils.py
Line 656:                              close_fds=True, shell=True, stdin=subprocess.PIPE,
it's not really fair to say this now, but it could be a great opportunity to get rid of this shell=True. Your call.

--
To view, visit http://gerrit.usersys.redhat.com/720
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id569873cadf794ea97aa95c3e1f775b2e7bce049
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list