Change in vdsm[master]: Related to BZ#720911 - Move filtering logic to LVMCache Clas...

danken at redhat.com danken at redhat.com
Sun Jul 24 20:31:44 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#720911 - Move filtering logic to LVMCache Class
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/lvm.py
Line 220:     return conf.replace("\n", " ")
it's pretty silly, but this latter replacement could have been done once, where LVMCONF_TEMPLATE is defined.

--
To view, visit http://gerrit.usersys.redhat.com/740
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4388596ea35c8fc9d097fe1f71a4c42a9b46087a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list