[NEW PATCH] Related to BZ#720911 - Split LVMSetup() (via gerrit-bot)
Saggi Mizrahi
smizrahi at redhat.com
Sun Jul 24 16:34:55 UTC 2011
New patch submitted by Saggi Mizrahi (smizrahi at redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/738
commit 2725c61877afffab21c423622e3396918d541fea
Author: Saggi Mizrahi <smizrahi at redhat.com>
Date: Sun Jul 24 18:57:57 2011 +0300
Related to BZ#720911 - Split LVMSetup()
Change-Id: Iab6732bbd4ff1f509d951b8a234fd39f50209301
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 3f0173c..8b08a24 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -242,16 +242,16 @@ def updateLvmConf():
-def setupLVM():
- updateFilter()
- try:
- lvmenvfname = os.path.join(VAR_RUN_VDSM, "lvm.env")
- lvmenv = file(lvmenvfname, "w")
+def _setupLVMEnv():
+ lvmenvfname = os.path.join(VAR_RUN_VDSM, "lvm.env")
+ with file(lvmenvfname, "w") as lvmenv:
lvmenv.write("export LVM_SYSTEM_DIR=%s\n" % VDSM_LVM_SYSTEM_DIR)
- lvmenv.close()
- except IOError, e:
- log.warning("Cannot create %s file %s", lvmenvfname, str(e))
+def _setupLVM():
+ try:
+ _setupLVMEnv()
+ except IOError, e:
+ log.warning("Cannot create env file %s", e)
#
# Make sure that "args" is suitable for consumption in interfaces
@@ -344,7 +344,6 @@ class LVMCache(object):
return newcmd
def __init__(self):
- setupLVM()
self._oplock = misc.OperationMutex()
self._stalepv = True
self._stalevg = True
More information about the vdsm-patches
mailing list