Change in vdsm[master]: BZ#694026 initctl libvirtd as part of its configuration vds...

danken at redhat.com danken at redhat.com
Thu Jul 21 21:51:48 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#694026  initctl libvirtd as part of its configuration vdsm use to control libvirtd using System V init script.  The changes have been made so that vdsm start uses initctl to start libvirtd. If libvirtd is already using initctl, then it will start libvi
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(5 inline comments)

....................................................
Commit Message
Line 7: BZ#694026  initctl libvirtd as part of its configuration
newline

....................................................
File vdsm.spec.in
Line 157:     cp -f $upstart /etc/init/libvirtd.conf
we must NOT do that upon installation. only after vdsmd is registered and working.

Line 194:             service libvirtd restart
why did you drop the removal of the upstart script? we add it, so we should remove it.

....................................................
File vdsm/vdsmd
Line 349:        cp -f $upstart /etc/init/libvirtd.conf
sorry, I still do not get why we need a copy (instead of a soft link).

Line 355:     initctl status libvirtd | grep -q "libvirtd stop" && initctl start libvirtd;
isn't 

initctl start libvirtd

a good replacement for the last two lines?

--
To view, visit http://gerrit.usersys.redhat.com/675
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea7b64a710b6e2c48fb96da82ebea64fd0482a4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sanjay Mehrotra <smehrotr at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list