Change in vdsm[master]: _initpv throws an unexpected exception.

Eduardo Warszawski ewarszaw at redhat.com
Thu Jul 21 15:13:27 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: _initpv throws an unexpected exception.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Minor minor, sorry.

....................................................
File vdsm/storage/lvm.py
Line 682:             log.warning("removeMappingsHoldingDevice() failed with %s" % device,
For consistency sake:
log.warning("removeMappingsHoldingDevice() failed with %s", device,...)

IMHO this remove should not be here.

--
To view, visit http://gerrit.usersys.redhat.com/653
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05e55b361df1523d970428d5453f36e98b2c9a2b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list