Change in vdsm[master]: BZ#694026 initctl libvirtd as part of its configuration vds...

Sanjay Mehrotra smehrotr at redhat.com
Wed Jul 20 21:47:13 UTC 2011


Sanjay Mehrotra has posted comments on this change.

Change subject: BZ#694026  initctl libvirtd as part of its configuration vdsm use to control libvirtd using System V init script.  The changes have been made so that vdsm start uses initctl to start libvirtd. If libvirtd is already using initctl, then it will start libvi
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/vdsmd
Line 345:     if ! initctl list | grep -q libvirtd
Worked further on the whole function start_libvirtd. This function handles output better than the previous ones. 

start_libvirtd() { 
initctl status libvirtd | grep -q  "libvirtd start" && return 0; 

< Now, libvirtd is either not running or just configured  or some one has removed libvirtd upstart file. So, rest of code takes care of it> 

chkconfig libvirtd off && service libvirtd stop >/dev/null 2>&1

if initctl status libvirtd | grep -q "libvirtd stop" 
then 
   initctl start libvirtd
else 
   upstart=`rpm -ql libvirt | grep libvirtd.upstart`
   cp -f $upstart /etc/init/libvirtd.conf
   initctl reload-configuration && initctl start libvirtd 
fi 
}
Please let me know if this works for you.  I shall be running various tests before submitting the code.

--
To view, visit http://gerrit.usersys.redhat.com/675
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea7b64a710b6e2c48fb96da82ebea64fd0482a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sanjay Mehrotra <smehrotr at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list