Change in vdsm[master]: BZ#694026 initctl libvirtd as part of its configuration vds...

Sanjay Mehrotra smehrotr at redhat.com
Wed Jul 20 18:17:43 UTC 2011


Sanjay Mehrotra has posted comments on this change.

Change subject: BZ#694026  initctl libvirtd as part of its configuration vdsm use to control libvirtd using System V init script.  The changes have been made so that vdsm start uses initctl to start libvirtd. If libvirtd is already using initctl, then it will start libvi
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File vdsm.spec.in
Line 158: fi
Ok. Will copy the libvirtd.upstart directly to the /etc/init directory.

....................................................
File vdsm/vdsmd
Line 345:     if ! initctl list | grep -q libvirtd
There is a disconnect here.  

Replacing initctl list | grep -q libvirtd  to 
initctl status libvirtd >/dev/null 2>&1 is the discussion.   In my view, it did not appear to be elegant solution when we are running libvirtd status command thrice.  As a code reader, libvirtd status above does not tell me a whole lot, except that we are looking for return status.   In fact, that's all we need in either commands,  so we will go ahead and implement - initctl status libvirtd as shown above. 

My line of communication was more on having a single  libvirtd status, then doing a grep on the output,  which is not possible as stderr comes in our way when libvirtd is not configured.

Line 348:        cp -f /etc/vdsm/libvirtd.upstart /etc/init/libvirtd.conf
Since we are now copying libvirtd.upstart directly to /etc/init/ directory ( refer post install script),  the logic will change here. This code path will only get executed when libvirtd.conf is removed from the /etc/init directory. 
It will be replaced now as 
cp -f $upstart /etc/init/libvirtd.conf where $upstart is the location from libvirtd.upstart

Further, when we check the status, ( line 356), we also have turn off the sysv service libvirtd.

--
To view, visit http://gerrit.usersys.redhat.com/675
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea7b64a710b6e2c48fb96da82ebea64fd0482a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sanjay Mehrotra <smehrotr at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list