netlink-based ifconfig() routine replacement

Peter V. Saveliev peet at altlinux.org
Wed Jul 20 17:14:20 UTC 2011


On 19.07.2011 16:58, Dan Kenigsberg wrote:
<skip />
> Please check your code with pyflakes (you can do make pyflakes), there
> are a couple of warnings there.

Fixed

> 
> Please add your new nlconfig file to vdsm.spec and Makefile.

Fixed
<skip />
> You could have minimized the size of the patch even further, if you had
> used netinfo.nlconfig whereever needed - there is no need to import
> nlconfig from here. I think it would be nicer to have nlconfig
> "internal" to netinfo.
<skip />
> I'm not sure we are ready to remove ifconfig just yet (see deployUtil
> comment). How about importing nlconfig.nlconfig as ifconfig ?

Yes, you're right. Done (just as «from nlconfig import nlconfig as
ifconfig»)

<skip />
> deployUtil.py should keep running on RHEL-5, with python 2.4, and vdsm22 -
> that does not have nlconfig. That's why I'd like the new code to hidden
> within netinfo.ifconfig.

Ok

The diff between «master» branch and «nlconfig» branch attached.


Also fixed sequence number checking on netlink messages — without it log
messages (that are generated by kernel for some network events) could
interfere with nlconfig() request.
-- 
Peter V. Saveliev
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nlconfig.diff
Url: https://fedorahosted.org/pipermail/vdsm-patches/attachments/20110720/a2643c1e/attachment-0001.pl 


More information about the vdsm-patches mailing list