Change in vdsm[master]: BZ#694408 - Don't return error code 358 (domain doesn't exis...
Igor Lvovsky
ilvovsky at redhat.com
Wed Jul 20 10:39:07 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: BZ#694408 - Don't return error code 358 (domain doesn't exists) on corrupted domain
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 963: except KeyError:
Why you will get KeyError here? How metadata corruption related to this?
....................................................
File vdsm/storage/localFsSD.py
Line 89: except KeyError:
Why you will get KeyError here? How metadata corruption related to this?
....................................................
File vdsm/storage/nfsSD.py
Line 133: except KeyError:
Why you will get KeyError here?
How metadata corruption related to this?
....................................................
File vdsm/storage/sdc.py
Line 102: self.log.error("Error while looking for domain `%s`", sdUUID, exc_info=True)
If you raise exception in CorruptedDomain, why you didn't raise it here?
Should we?
You changed function behaviour here, is it work for all cases?
....................................................
File vdsm/storage/storage_exception.py
Line 705: self.message = "Domain's %s is mounted but metafile is corrupted on path %s" % (sdUUID, domainPath)
'Domain is mounted' is only for NFS domains. What about block?
Line 706: code = 399
Don't forget to publish this to RHEV-M team
--
To view, visit http://gerrit.usersys.redhat.com/723
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5aa4d541e9d4ccfe4721560375c0077f979634bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list