Change in vdsm[master]: BZ#720981 - Don't rely on files in /dev/mapper to be symlink...

Igor Lvovsky ilvovsky at redhat.com
Wed Jul 20 10:11:53 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: BZ#720981 - Don't rely on files in /dev/mapper to be symlinks
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 54:     mpName = resolveDevName(deviceName)
resolveDevName(devName) can return devName itself instead of DmId.
It'a a different logic from previous getSlaves.

--
To view, visit http://gerrit.usersys.redhat.com/717
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e1669e994834602e7c9cb655fbac31fe666bafe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list