Change in vdsm[master]: BZ#720257 - Don't produce domain on teardown

danken at redhat.com danken at redhat.com
Tue Jul 19 21:45:39 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#720257 - Don't produce domain on teardown
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 1668:         lockType = rm.LockType.exclusive
do you find this clearer than the perl-like

lockType = rm.LockType.exclusive if rw else rm.LockType.shared

? I don't.

Line 1673
so you say this prepare (and the preceeding refresh) where redundant? Please add a reassuring word to the commit message, explaining why the feared NB is no longer relevant.

Line 1689:         :param rw: Should the voulme be set as RW. ?
hmmm, I guess that "rw" arg should better be marked as obsolete (unrelated to this patch)

Line 1695:             imgResource = self._preparedVolumes[sdUUID + volUUID].pop()
we do not care if the popped imgResource matches our imgUUID? I find it odd that you no longer use that arg.

--
To view, visit http://10.35.18.144/724
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf3311790a7927e3bf3d5e7a4820462d213bcdb6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list