Change in vdsm[master]: BZ#694026 initctl libvirtd as part of its configuration vds...

danken at redhat.com danken at redhat.com
Sat Jul 16 06:25:48 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#694026  initctl libvirtd as part of its configuration vdsm use to control libvirtd using System V init script.  The changes have been made so that vdsm start uses initctl to start libvirtd. If libvirtd is already using initctl, then it will start libvi
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/vdsmd
Line 345:     if ! initctl list | grep -q libvirtd
"revert back"? what do you mean?

you can hide stderr with 2>/dev/null.

Line 348:        cp -f /etc/vdsm/libvirtd.upstart /etc/init/libvirtd.conf
I'd like to understand why a soft link is prohibited. either way, /etc/vdsm/libvirtd.upstart should not exist.

--
To view, visit http://gerrit.usersys.redhat.com/675
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea7b64a710b6e2c48fb96da82ebea64fd0482a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sanjay Mehrotra <smehrotr at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list