Change in vdsm[master]: BZ#694026 initctl libvirtd as part of its configuration vds...

danken at redhat.com danken at redhat.com
Fri Jul 15 19:49:41 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#694026  initctl libvirtd as part of its configuration vdsm use to control libvirtd using System V init script.  The changes have been made so that vdsm start uses initctl to start libvirtd. If libvirtd is already using initctl, then it will start libvi
......................................................................


Patch Set 3: (4 inline comments)

....................................................
File vdsm.spec.in
Line 158: fi
please do not have an intermediate copy of libvirtd.upstart in /etc/vdsm. duplicating data is evil. use a single soft link.

....................................................
File vdsm/vdsmd
Line 345:     if ! initctl list | grep -q libvirtd
yes, but we want to know that *status* of libvirtd - whether it is running or not. afaict, initctl status gives us just that.

Line 348:        cp -f /etc/vdsm/libvirtd.upstart /etc/init/libvirtd.conf
it is not our business to customize this script. it is shipped with libvirt, and it si libvirt's responsibility to do right.

Line 358:        service libvirtd condrestart
no, we are configuring libvirt to use upstart and upstart only. if there is a bug in that configuration, either we or libvirt will fix it.

we do not want to worry about both upstart and sysv.

--
To view, visit http://gerrit.usersys.redhat.com/675
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea7b64a710b6e2c48fb96da82ebea64fd0482a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Sanjay Mehrotra <smehrotr at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list