Change in vdsm[master]: Related to BZ#719255 - Release lock if prepare volume failed

danken at redhat.com danken at redhat.com
Thu Jul 14 12:26:46 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#719255 - Release lock if prepare volume failed
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1675:             rmanager.releaseResource(imageResourcesNamespace, imgUUID)
when I suggested that, you said autoRelease was prettier. Why now? Please explain the benefits in the commit message.

--
To view, visit http://gerrit.usersys.redhat.com/709
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eeeda07037824bb822b8d0d1fff869959bdfefc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list