Change in vdsm[master]: BZ#720911 - Update lvm cache filter when storage changes
danken at redhat.com
danken at redhat.com
Thu Jul 14 08:22:40 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#720911 - Update lvm cache filter when storage changes
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 880: self._initVmStats()
a separate patch, with an explanation
_initVmStats() needs the drive info to work properly
would be nice.
....................................................
File vdsm/storage/spm.py
Line 1071: # The old API was designed thinking that having a lost of verbs is complicated
lost --> lot
Line 1076: pool.destroy()
I believe you, but how is it related to the bug you are solving?
--
To view, visit http://gerrit.usersys.redhat.com/698
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I375a6407782a0cb1d3fe61b2c5f437ea6ecfe9fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
More information about the vdsm-patches
mailing list