Change in vdsm[master]: BZ#705058 - StoragePool instanciations should be lock protec...

danken at redhat.com danken at redhat.com
Wed Jul 13 16:03:07 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#705058 - StoragePool instanciations should be lock protected.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 165:             spUUID = os.listdir(_poolsTmpDir)[0]
why did you drop the 'for' loop? now we have an exception problem if _poolsTmpDir is empty. this has no functional effect, but it's not nice.

--
To view, visit http://gerrit.usersys.redhat.com/700
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ad3cdb07299d63203db98ae3223559b6fdc4eab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list