Change in vdsm[master]: BZ#712106 - Add lock for template during moveImage operation

Saggi Mizrahi smizrahi at redhat.com
Tue Jul 12 07:22:19 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#712106 - Add lock for template during moveImage operation
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(6 inline comments)

....................................................
File vdsm/storage/image.py
Line 330:             self.log.error("There is no leaf in the image %s" % imgUUID)
use comma not %

Line 483:             raise se.SourceImageActionError(imgUUID, srcSdUUID, str(e))
No need to pass str(e)

Line 497:                 fakeTemplate = True
Extract function isParentFake

Line 521:                     tmpSize = 20480 # in sectors (10M)
use string and state in bytes

Line 551:         except Exception, e:
e, unused?

Line 637:                 pass
I don't like except Exception, pass. You are expecting something

--
To view, visit http://gerrit.usersys.redhat.com/630
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib87649cf0aebd5a35d56faa7e8f165d10d715331
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list