[NEW PATCH] BZ#718993 - Remove vgchange --refresh (via gerrit-bot)
Eduardo Warszawski
ewarszaw at redhat.com
Thu Jul 7 02:25:33 UTC 2011
New patch submitted by Eduardo Warszawski (ewarszaw at redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/662
commit 8e2a1b9332d66cde99b46de62f7ea5d4efad641d
Author: Eduardo Warszawski <ewarszaw at redhat.com>
Date: Tue Jul 5 18:05:39 2011 +0300
BZ#718993 - Remove vgchange --refresh
vgchange --refresh:
If any logical volume in the volume group is active, reload its metadata.
vgchange --refresh may be too long when are many LVs in the VG.
vgchange --refresh was NOT needed for refreshLV after migration in bug 651803,
since the LV metadata is reloaded using lvchange --refresh.
Change-Id: I123480a2f687bbfacaf8308fbfa3d0a7f5c29c47
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 9f744b2..0c00dd3 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -105,7 +105,7 @@ class VGTagMetadataRW(object):
self._vgName = vgName
def readlines(self):
- lvm.refreshVG(self._vgName)
+ lvm.invalidateVG(self._vgName)
vg = lvm.getVG(self._vgName)
metadata = []
for tag in vg.tags:
@@ -921,7 +921,7 @@ class BlockStorageDomain(sd.StorageDomain):
def refresh(self):
self.refreshDirTree()
- lvm.refreshVG(self.sdUUID)
+ lvm.invalidateVG(self.sdUUID)
self._metadata = selectMetadata(self.sdUUID)
@staticmethod
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index d6159eb..8a89a01 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -881,14 +881,9 @@ def deactivateVG(vgName):
_setVgAvailability(vgName, available="n")
-def refreshVG(vgName):
- #If any logical volume in the volume group is active, reload its metadata.
- cmd = ['vgchange', '--refresh', vgName]
- rc, out, err = _lvminfo.cmd(cmd)
+def invalidateVG(vgName):
_lvminfo._invalidatevgs(vgName)
_lvminfo._invalidatelvs(vgName)
- if rc != 0:
- raise se.LogicalVolumeRefreshError("vgchange --refresh %s failed" % (vgName,))
#
More information about the vdsm-patches
mailing list